| Summary: | Implement a BeforeLoadEvent constructor for JSC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ap, dominicc, sam, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 67824 | ||||||
| Attachments: |
|
||||||
Created attachment 110644 [details]
Patch
Comment on attachment 110644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110644&action=review > Source/WebCore/dom/BeforeLoadEvent.h:38 > + BeforeLoadEventInit() > + { > + }; You can these all on one line with a space between the { } if you want. Comment on attachment 110644 [details] Patch Rejecting attachment 110644 [details] from commit-queue. haraken@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Kentaro, you're not a committer? Oh, maybe you have @chromium.org and @google.com account in bugzilla? (In reply to comment #5) > Oh, maybe you have @chromium.org and @google.com account in bugzilla? Yes, sorry, I marked cq+ on @google.com by mistake... And thank you for cq+ this! Comment on attachment 110644 [details] Patch Clearing flags on attachment: 110644 Committed r97324: <http://trac.webkit.org/changeset/97324> All reviewed patches have been landed. Closing bug. |
We have been implementing constructors of Events. BeforeLoadEvent should have a constructor. There is no spec for the BeforeLoadEvent constructor, since it is WebKit-specific. Judging from the current IDL of initBeforeLoadEvent(), the IDL of the BeforeLoadEvent constructor should be as follows. [Constructor(DOMString type, optional BeforeLoadEventInit eventInitDict)] interface BeforeLoadEvent : Event { ...; } dictionary BeforeLoadEventInit : EventInit { DOMString url; }