Bug 69893 - Implement a BeforeLoadEvent constructor for JSC
Summary: Implement a BeforeLoadEvent constructor for JSC
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 67824
  Show dependency treegraph
Reported: 2011-10-11 18:57 PDT by Kentaro Hara
Modified: 2011-10-12 17:34 PDT (History)
5 users (show)

See Also:

Patch (14.05 KB, patch)
2011-10-11 23:35 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-10-11 18:57:36 PDT
We have been implementing constructors of Events. BeforeLoadEvent should have a constructor. 

There is no spec for the BeforeLoadEvent constructor, since it is WebKit-specific. Judging from the current IDL of initBeforeLoadEvent(), the IDL of the BeforeLoadEvent constructor should be as follows.

[Constructor(DOMString type, optional BeforeLoadEventInit eventInitDict)]
interface BeforeLoadEvent : Event {

dictionary BeforeLoadEventInit : EventInit {
    DOMString url;
Comment 1 Kentaro Hara 2011-10-11 23:35:36 PDT
Created attachment 110644 [details]
Comment 2 Adam Barth 2011-10-12 09:45:37 PDT
Comment on attachment 110644 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=110644&action=review

> Source/WebCore/dom/BeforeLoadEvent.h:38
> +    BeforeLoadEventInit()
> +    {
> +    };

You can these all on one line with a space between the { } if you want.
Comment 3 WebKit Review Bot 2011-10-12 16:39:48 PDT
Comment on attachment 110644 [details]

Rejecting attachment 110644 [details] from commit-queue.

haraken@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 Adam Barth 2011-10-12 16:40:41 PDT
Kentaro, you're not a committer?
Comment 5 Adam Barth 2011-10-12 16:41:22 PDT
Oh, maybe you have @chromium.org and @google.com account in bugzilla?
Comment 6 Kentaro Hara 2011-10-12 16:44:52 PDT
(In reply to comment #5)
> Oh, maybe you have @chromium.org and @google.com account in bugzilla?

Yes, sorry, I marked cq+ on @google.com by mistake...
And thank you for cq+ this!
Comment 7 WebKit Review Bot 2011-10-12 17:34:25 PDT
Comment on attachment 110644 [details]

Clearing flags on attachment: 110644

Committed r97324: <http://trac.webkit.org/changeset/97324>
Comment 8 WebKit Review Bot 2011-10-12 17:34:30 PDT
All reviewed patches have been landed.  Closing bug.