Bug 69889 – Selection is not collapsed in some WK2 editing tests

• Component: Tools / Tests
• Status: REOPENED

[Simon Fraser (smfr)]

These tests, and some others, are failing in WK2 because the selection is not collapsed at the end of the test:

editing/pasteboard/drag-drop-iframe-refresh-crash.html: pretty diff
editing/selection/caret-ltr-right.html: pretty diff
editing/selection/caret-rtl-right.html: pretty diff
editing/selection/select-across-readonly-input-2.html: pretty diff
editing/selection/select-across-readonly-input-3.html: pretty diff
editing/selection/select-across-readonly-input-4.html: pretty diff
editing/selection/select-across-readonly-input-5.html: pretty diff

[Simon Fraser (smfr)]

Also
editing/inserting/caret-position.html

[Ryosuke Niwa]

Maybe it's something to do with eventSender in WK2?

[Chang Shu]

editing/inserting/caret-position.html is calling textInputController.firstRectForCharacterRange(0, 0).
But it's not supported yet in WK2. There must be other unsupported textInputController functions used in these tests.

[Simon Fraser (smfr)]

I skipped editing/inserting/caret-position.html in WK2 already. The other tests still have the problem described.

[Chang Shu]

I believe the failures are related to missing drag-n-drop support in WK2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=68552.

[Simon Fraser (smfr)]

But not all those tests involve D&D

[Chang Shu]

I think these tests are new and never passed in WK2. We should simply skip them for now. Understanding the cause of the failures will help us to put them in the right category. D&D and textInputController are two root causes I have identified so far.

[Simon Fraser (smfr)]

D&D and textInputController tests have already been skipped. These tests are using neither (but do rely on event sender).

[Ryosuke Niwa]

(In reply to comment #7)
> I think these tests are new and never passed in WK2. We should simply skip them for now. Understanding the cause of the failures will help us to put them in the right category. D&D and textInputController are two root causes I have identified so far.

caret-ltr-right and caret-rtl-right should be passing on WK2.

[Chang Shu]

(In reply to comment #8)
> D&D and textInputController tests have already been skipped. These tests are using neither (but do rely on event sender).

LayoutTests/editing/selection/resources/select-across-readonly-input.js should depend on D&D:
        moveMouseToMiddleOfElement(document.getElementById('from'));
        eventSender.mouseDown();

        eventSender.leapForward(200);

        moveMouseToMiddleOfElement(document.getElementById('to'));
        eventSender.mouseUp();

and LayoutTests/editing/inserting/caret-position.html should depend on textInputController.firstRectForCharacterRange:

function testCaretPosition(elementId, caretPosition)
{
    e = document.getElementById(elementId, caretPosition);
    e.focus();
    if (window.textInputController) {
        var caretRect = textInputController.firstRectForCharacterRange(0, 0);
        assertEqual(elementId, caretRect[0], caretPosition);
    }  
}

[Simon Fraser (smfr)]

Chang: please make a patch to disable the appropriate tests then.

[Chang Shu]

(In reply to comment #11)
> Chang: please make a patch to disable the appropriate tests then.

No problem.

[Chang Shu]

Created attachment 110712 [details]
patch 1

Added failed tests to Skip list. I put them into platform-dependent Skipped file instead of the common one because the fix should be platform-dependent.

[WebKit Review Bot]

Comment on attachment 110712 [details]
patch 1

Clearing flags on attachment: 110712

Committed r97297: <http://trac.webkit.org/changeset/97297>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Reopen the bug because the patch didn't really fix the tests.

[Jessie Berlin]

caret-ltr-right and caret-rtl-right are not passing in WK2:

http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110889%20(4971)/editing/selection/caret-ltr-right-pretty-diff.html
http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110889%20(4971)/editing/selection/caret-rtl-right-pretty-diff.html

Ryosuke, why did you think they should be passing?

[Jessie Berlin]

Added failing expected results for mac-wk2 in http://trac.webkit.org/changeset/110906