Bug 69884

Summary: Rename virtual deleteProperty to deletePropertyVirtual
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+, webkit.review.bot: commit-queue-

Mark Hahnenberg
Reported 2011-10-11 17:02:06 PDT
Since the compiler cannot tell the difference between virtual deleteProperty and static deleteProperty, we need to rename virtual deleteProperty to deletePropertyVirtual in preparation for adding static deleteProperty to the MethodTable in ClassInfo. See also bug 69810.
Attachments
Patch (67.99 KB, patch)
2011-10-11 17:18 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (69.11 KB, patch)
2011-10-12 11:42 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (69.66 KB, patch)
2011-10-13 10:19 PDT, Mark Hahnenberg 		darin: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-11 17:18:39 PDT
Created attachment 110613 [details] Patch
Mark Hahnenberg
Comment 2 2011-10-12 11:42:51 PDT
Created attachment 110715 [details] Patch
Mark Hahnenberg
Comment 3 2011-10-13 10:19:54 PDT
Created attachment 110869 [details] Patch
WebKit Review Bot
Comment 4 2011-10-14 12:13:35 PDT
Comment on attachment 110869 [details] Patch Rejecting attachment 110869 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: . patching file Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h patching file Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10068413
Mark Hahnenberg
Comment 5 2011-10-14 14:18:55 PDT
Committed r97506: <http://trac.webkit.org/changeset/97506>
Patrick R. Gansterer
Comment 6 2011-10-17 02:09:31 PDT
Committed interpreter build fix r97593: <http://trac.webkit.org/changeset/97593> Please watch the bots. THX!
Note You need to log in before you can comment on or make changes to this bug.