Bug 69872

Summary: Rename virtual getConstructData to getConstructDataVirtual
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, msaboff, paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Hahnenberg
Reported 2011-10-11 14:56:57 PDT
Since the compiler cannot tell the difference between virtual getConstructData and static getConstructData, we need to rename virtual getConstructData to getConstructDataVirtual in preparation for adding static getConstructData to the MethodTable in ClassInfo. See also bug 69810.
Attachments
Patch (44.20 KB, patch)
2011-10-11 15:15 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (45.25 KB, patch)
2011-10-12 11:45 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (45.34 KB, patch)
2011-10-13 10:13 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-11 15:15:19 PDT
Created attachment 110586 [details] Patch
Mark Hahnenberg
Comment 2 2011-10-12 11:45:40 PDT
Created attachment 110716 [details] Patch
Mark Hahnenberg
Comment 3 2011-10-13 10:13:43 PDT
Created attachment 110866 [details] Patch
Michael Saboff
Comment 4 2011-10-13 14:43:25 PDT
Straightforward and looks fine.
Geoffrey Garen
Comment 5 2011-10-13 17:15:37 PDT
Comment on attachment 110866 [details] Patch r=me
WebKit Review Bot
Comment 6 2011-10-13 19:21:51 PDT
Comment on attachment 110866 [details] Patch Clearing flags on attachment: 110866 Committed r97436: <http://trac.webkit.org/changeset/97436>
WebKit Review Bot
Comment 7 2011-10-13 19:21:56 PDT
All reviewed patches have been landed. Closing bug.
Patrick R. Gansterer
Comment 8 2011-10-17 02:08:36 PDT
Committed interpreter build fix r97593: <http://trac.webkit.org/changeset/97593>
Note You need to log in before you can comment on or make changes to this bug.