| Summary: | DFG JIT 32_64 - Switch to cdecl calling convention. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gavin Barraclough
2011-10-11 13:39:38 PDT
Created attachment 110570 [details]
The patch
Attachment 110570 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.h:87: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1252: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 110570 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=110570&action=review r=me, fix the spelling error and the sizeof<SPACE!!!!>( style error > Source/JavaScriptCore/ChangeLog:8 > + This makes it easier to keep the stack correctly aligned, which is reuired on OS X. required. r-!!!!!111!!!1!!!111!1 > Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1060 > + m_jit.move(Imm32(numConstants), GPRInfo::argumentGPR2); > + m_jit.move(Imm32(startConstant), GPRInfo::argumentGPR1); well caught sir! >> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1252 >> + m_jit.storeDouble(value, JITCompiler::Address(JITCompiler::stackPointerRegister, m_callArgumentIndex * sizeof (void*))); > > Extra space before ( in function call [whitespace/parens] [4] This is a real style bug in the sizeof |