Bug 69851

Summary: Rename virtual put to putVirtual
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gustavo.noronha, gustavo, paroga, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Fix builds
none
Fix windows
none
Fix gtk
none
Fix gtk darin: review+, webkit.review.bot: commit-queue-

Mark Hahnenberg
Reported 2011-10-11 10:47:31 PDT
Since the compiler cannot tell the difference between virtual put and static put, we need to rename virtual put to putVirtual in preparation for adding static put to the MethodTable in ClassInfo. See also bug 69810.
Attachments
Patch (110.59 KB, patch)
2011-10-11 11:00 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix builds (115.50 KB, patch)
2011-10-12 11:54 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix windows (116.14 KB, patch)
2011-10-13 10:33 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix gtk (116.20 KB, patch)
2011-10-14 10:24 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix gtk (116.19 KB, patch)
2011-10-14 11:09 PDT, Mark Hahnenberg 		darin: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-11 11:00:39 PDT
Created attachment 110540 [details] Patch
Early Warning System Bot
Comment 2 2011-10-11 11:22:50 PDT
Comment on attachment 110540 [details] Patch Attachment 110540 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10029580
Collabora GTK+ EWS bot
Comment 3 2011-10-11 16:19:53 PDT
Comment on attachment 110540 [details] Patch Attachment 110540 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10031581
Gustavo Noronha (kov)
Comment 4 2011-10-11 16:46:55 PDT
Comment on attachment 110540 [details] Patch Attachment 110540 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10029667
Mark Hahnenberg
Comment 5 2011-10-12 11:54:50 PDT
Created attachment 110717 [details] Fix builds
Collabora GTK+ EWS bot
Comment 6 2011-10-13 00:02:33 PDT
Comment on attachment 110717 [details] Fix builds Attachment 110717 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10060076
Mark Hahnenberg
Comment 7 2011-10-13 10:33:45 PDT
Created attachment 110872 [details] Fix windows
Collabora GTK+ EWS bot
Comment 8 2011-10-13 19:21:28 PDT
Comment on attachment 110872 [details] Fix windows Attachment 110872 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10056387
Mark Hahnenberg
Comment 9 2011-10-14 10:24:07 PDT
Created attachment 111026 [details] Fix gtk
Mark Hahnenberg
Comment 10 2011-10-14 11:09:21 PDT
Created attachment 111030 [details] Fix gtk
WebKit Review Bot
Comment 11 2011-10-14 15:09:26 PDT
Comment on attachment 111030 [details] Fix gtk Rejecting attachment 111030 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h Hunk #1 succeeded at 86 with fuzz 2. patching file Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp patching file Source/autotools/symbols.filter Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10060688
Mark Hahnenberg
Comment 12 2011-10-14 17:04:04 PDT
Committed r97532: <http://trac.webkit.org/changeset/97532>
Patrick R. Gansterer
Comment 13 2011-10-17 02:09:49 PDT
Committed interpreter build fix r97593: <http://trac.webkit.org/changeset/97593>
Note You need to log in before you can comment on or make changes to this bug.