Bug 69833

Summary: Web Inspector: make Extensions component compile.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] Same with settings screen and test controller yurys: review+

Description Pavel Feldman 2011-10-11 06:17:12 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-10-11 06:21:19 PDT 
Created attachment 110508 [details]
Patch
Comment 2 Pavel Feldman 2011-10-11 06:28:06 PDT 
Created attachment 110509 [details]
[Patch] Same with settings screen and test controller
Comment 3 Yury Semikhatsky 2011-10-11 06:44:27 PDT 
Comment on attachment 110509 [details]
[Patch] Same with settings screen and test controller

View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review

> Source/WebCore/inspector/front-end/TestController.js:-50
> -                result = window[script].call(WebInspector, controller);

Please make sure this code is not used.
Comment 4 Andrey Kosyakov 2011-10-11 06:52:58 PDT 
Comment on attachment 110509 [details]
[Patch] Same with settings screen and test controller

View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review

> Source/WebCore/inspector/front-end/ExtensionAPI.js:-383
> -    createResult: function()

This is an API method, this will break extension API interface.
Comment 5 Pavel Feldman 2011-10-11 07:42:55 PDT 
Committed r97152: <http://trac.webkit.org/changeset/97152>