Bug 69816

Summary: REGRESSION (WebKit2): Document marker added by find looks odd when found text is split by inline elements
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: andersca, ap, darin, enrica, jiapu.mail, mitz, morrita, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
screenshot none

Ryosuke Niwa
Reported 2011-10-10 22:22:29 PDT
Created attachment 110475 [details] screenshot Reproduction steps 1. Open https://bugs.webkit.org/attachment.cgi?id=110462&action=review on ToT WebKit 2. Search for "recalcListItemsInternal" Expected result: Every instance of "recalcListItemsInternal" is highlighted properly Actual result: Some instances of "recalcListItemsInternal" are highlighted by chunks of document markers.
Attachments
screenshot (29.40 KB, image/png)
2011-10-10 22:22 PDT, Ryosuke Niwa 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 2 2011-10-12 02:10:32 PDT
It looks markers are actually splited because each marker is associated to a text node, not to a range. I guess its design haven't changed from beginning. But something is apparently wrong. The problem is that WebKit2(safari) paint textmatch marker hightlight to animate it. (Other ports seem to use InlineTextBox::paintTextMatchMarker(), a non-animated version.) I have no idea what type of fix is good for the Safari's implementation.
Alexey Proskuryakov
Comment 3 2011-10-12 08:30:24 PDT
Why did you remove "REGRESSION (WebKit2)" prefix from the title? This is a regression from WK1 to WK2.
Alexey Proskuryakov
Comment 4 2011-12-25 21:23:48 PST
Sounds like this got fixed today. *** This bug has been marked as a duplicate of bug 75220 ***
mitz
Comment 5 2011-12-25 21:25:49 PST
Sorry, everyone, I did not know about this bug before I filed bug 752220.
Note You need to log in before you can comment on or make changes to this bug.