Bug 69810

Summary:

Rename getOwnPropertySlot to getOwnPropertySlotVirtual

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, ggaren, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67690, 69807

Attachments:

Description	Flags
Patch	none
Patch	none
Reset bindings	none
Fix windows	none
Fix windows	none
Patch	none
Patch	none

Mark Hahnenberg

Reported 2011-10-10 18:55:43 PDT

The compiler gets confused when we try to put getOwnPropertySlot into the method table when there is both a virtual and static version of the method (but it doesn't get confused when there are two static methods with different types). Therefore, we need to temporarily rename the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual. This will avoid the conflict later on when we add getOwnPropertySlot to the MethodTable in ClassInfo.

Attachments
Patch (138.51 KB, patch) 2011-10-10 19:47 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (138.58 KB, patch) 2011-10-10 19:56 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Reset bindings (170.41 KB, patch) 2011-10-10 20:10 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Fix windows (164.23 KB, patch) 2011-10-11 10:32 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Fix windows (164.60 KB, patch) 2011-10-11 14:08 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (164.81 KB, patch) 2011-10-13 10:37 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (164.91 KB, patch) 2011-10-14 11:42 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.