Bug 69807

Summary: Add getOwnPropertySlot to MethodTable
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 69810    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch oliver: review+, webkit.review.bot: commit-queue-

Mark Hahnenberg
Reported 2011-10-10 18:06:33 PDT
We now need to add both versions of getOwnPropertySlot to the MethodTable in ClassInfo in preparation from removing the virtual version of getOwnPropertySlot.
Attachments
Patch (5.81 KB, patch)
2011-10-24 12:06 PDT, Mark Hahnenberg 		oliver: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-24 12:06:12 PDT
Created attachment 112228 [details] Patch
Oliver Hunt
Comment 2 2011-10-24 16:53:13 PDT
Comment on attachment 112228 [details] Patch r=me
WebKit Review Bot
Comment 3 2011-10-24 21:18:02 PDT
Comment on attachment 112228 [details] Patch Rejecting attachment 112228 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10210108
Mark Hahnenberg
Comment 4 2011-10-25 11:50:58 PDT
Committed r98367: <http://trac.webkit.org/changeset/98367>
Note You need to log in before you can comment on or make changes to this bug.