Bug 69806

Summary: DFG JIT switch dfgConvert methods to use callOperation
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch fpizlo: review+

Gavin Barraclough
Reported 2011-10-10 17:34:35 PDT
This is the last one!
Attachments
The patch (7.09 KB, patch)
2011-10-10 17:35 PDT, Gavin Barraclough 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-10-10 17:35:35 PDT
Created attachment 110449 [details] The patch
WebKit Review Bot
Comment 2 2011-10-10 17:38:43 PDT
Attachment 110449 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:91: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/dfg/DFGOperations.h:92: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2011-10-10 18:03:12 PDT
Fixed in r97117
Note You need to log in before you can comment on or make changes to this bug.