Bug 69749

Summary: [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 none

Description Philippe Normand 2011-10-10 03:18:27 PDT 
GtkTable has been deprecated in GTK+3.
Comment 1 Claudio Saavedra 2011-10-11 09:11:40 PDT 
Created attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Reviewed by NOBODY (OOPS!).

* platform/gtk/GtkAuthenticationDialog.cpp:
(WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
Ditto.
Comment 2 Martin Robinson 2011-10-11 09:54:35 PDT 
Comment on attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Hopefully this will look better once we remove GTK+ support. :)
Comment 3 WebKit Review Bot 2011-10-11 10:16:03 PDT 
Comment on attachment 110521 [details]
[GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749

Clearing flags on attachment: 110521

Committed r97161: <http://trac.webkit.org/changeset/97161>
Comment 4 WebKit Review Bot 2011-10-11 10:16:07 PDT 
All reviewed patches have been landed.  Closing bug.