Bug 69730
| Summary: | [GTK] Misnamed argument inverts semantics | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Bob Murphy <bobert> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | UNCONFIRMED | ||
| Severity: | Normal | CC: | berto, bugs-noreply, mrobinson |
| Priority: | P3 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Bob Murphy
In WebKitGtk 1.4.2, WebKitDomNode.cpp, the function webkit_dom_node_add_event_listener() accepts a "bubble" argument, and passes it unchanged to WebCore::GObjectEventListener::addEventListener().
However, the implementation of addEventListener(), in GObjectEventListener.h, has a "useCapture" argument at that same position. And digging past that, it does appear that argument means whether to fire the handler during the capture phase.
Xan Lopez confirmed this, and suggested submitting a patch to make the parameter name consistent with what it actually accomplishes, which I will do.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alberto Garcia
Ping