Summary: | CSP should log unrecognized directives to the console | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||||||
Component: | WebCore Misc. | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, sam, ulfar.erlingsson | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 53572 | ||||||||||
Attachments: |
|
Description
WebKit Review Bot
2011-10-09 13:15:04 PDT
Created attachment 110311 [details]
Patch
Comment on attachment 110311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review > Source/WebCore/page/ContentSecurityPolicy.h:80 > + void reportUnrecognizedDirective(const String& name) const; I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server. (In reply to comment #2) > (From update of attachment 110311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review > > > Source/WebCore/page/ContentSecurityPolicy.h:80 > > + void reportUnrecognizedDirective(const String& name) const; > > I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server. Perhaps logUnrecognizedDirective ? Created attachment 110312 [details]
Patch for landing
Comment on attachment 110312 [details] Patch for landing Rejecting attachment 110312 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ause.html = MISSING PASS Regressions: Unexpected text diff mismatch : (1) http/tests/security/contentSecurityPolicy/directive-parsing.html = TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Full output: http://queues.webkit.org/results/9995864 Created attachment 110313 [details]
Patch for landing
Comment on attachment 110313 [details] Patch for landing Clearing flags on attachment: 110313 Committed r97035: <http://trac.webkit.org/changeset/97035> All reviewed patches have been landed. Closing bug. |