Bug 69728 – CSP should log unrecognized directives to the console

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[WebKit Review Bot]

CSP should log unrecognized directives to the console
Requested by abarth on #webkit.

[Adam Barth]

Created attachment 110311 [details]
Patch

[Sam Weinig]

Comment on attachment 110311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review

> Source/WebCore/page/ContentSecurityPolicy.h:80
> +    void reportUnrecognizedDirective(const String& name) const;

I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server.

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 110311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110311&action=review
> 
> > Source/WebCore/page/ContentSecurityPolicy.h:80
> > +    void reportUnrecognizedDirective(const String& name) const;
> 
> I am not thrilled with using the word report here, as it has a subtle implication that it will have the same semantics as reportViolation, sending the report to the server.

Perhaps logUnrecognizedDirective ?

[Adam Barth]

Created attachment 110312 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110312 [details]
Patch for landing

Rejecting attachment 110312 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ause.html = MISSING PASS


Regressions: Unexpected text diff mismatch : (1)
  http/tests/security/contentSecurityPolicy/directive-parsing.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/9995864

[Adam Barth]

Created attachment 110313 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110313 [details]
Patch for landing

Clearing flags on attachment: 110313

Committed r97035: <http://trac.webkit.org/changeset/97035>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.