Bug 69726

Summary: Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Pavel Feldman
Reported 2011-10-09 12:09:53 PDT
This change adds types to the DOMAgent and Debugger model. Besides the comments, it introduces WebInspector.Event (the one user in WebInspector.Object); spits the returnByValue and non-returnByValue evaluate paths.
Attachments
Patch (99.59 KB, patch)
2011-10-09 12:19 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (110.44 KB, patch)
2011-10-10 07:44 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-09 12:19:13 PDT
Created attachment 110306 [details] Patch
Adam Barth
Comment 2 2011-10-09 14:39:26 PDT
Comment on attachment 110306 [details] Patch This patch is causing the cr-linux-ews to spin.
Pavel Feldman
Comment 3 2011-10-10 07:44:17 PDT
Created attachment 110358 [details] Patch
Yury Semikhatsky
Comment 4 2011-10-10 08:33:26 PDT
Comment on attachment 110358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110358&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:389 > + this._debuggerModel._parsedScriptSource(scriptId, sourceURL, startLine, startColumn, endLine, endColumn, isContentScript || false); !!isContentScript ? > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:573 > +WebInspector.PresentationConsoleMessage.prototype = { Remove this ?
Pavel Feldman
Comment 5 2011-10-10 10:02:17 PDT
Committed r97067: <http://trac.webkit.org/changeset/97067>
Note You need to log in before you can comment on or make changes to this bug.