Bug 69715

Summary: Do not compare the first glyph to itself in Font::drawGlyphBuffer()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Layout and RenderingAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-10-08 22:28:36 PDT
In Font::drawGlyphBuffer(): 1) the information of the first glyph is extracted 2) it is compared to itself, which never fails 3) then to the following glyphs are handled We can just skip the first iteration which make the code a bit easier to read and hopefully a tiny-little-bit faster :)
Attachments
Patch (1.71 KB, patch)
2011-10-08 22:38 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-10-08 22:38:13 PDT
Created attachment 110290 [details] Patch
Andreas Kling
Comment 2 2011-10-09 01:55:51 PDT
Comment on attachment 110290 [details] Patch r=me
WebKit Review Bot
Comment 3 2011-10-09 02:59:17 PDT
Comment on attachment 110290 [details] Patch Clearing flags on attachment: 110290 Committed r97023: <http://trac.webkit.org/changeset/97023>
WebKit Review Bot
Comment 4 2011-10-09 02:59:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.