Bug 69713

Summary: run-webkit-tests should accept --child-processes
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Tools / TestsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ojan Vafai
Reported 2011-10-08 18:48:42 PDT
It lists --child-processes as a valid commandline argument, but it always creates 1 process. I think this is a regression. It's fine to default to 1, but if you pass the flag, it should respect it. I had noticed recently the run-webkit-tests was taking forever even when I'd run with multiple child processes. I expect I might not be the only one surprised by this.
Attachments
Patch (1.74 KB, patch)
2011-10-15 15:14 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (1.56 KB, patch)
2011-10-15 16:09 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-10-09 08:55:38 PDT
That would be an odd regression. I'll look on monday, now that I'm done with the CSS regression stuff. If you run "new-run-webkit-tests" directly does child-processes work as you expect? the "run-webkit-tests" wrapper overrides --child-process to 1.
Ojan Vafai
Comment 2 2011-10-09 19:07:25 PDT
It works correctly if I just new-run-webkit-tests directly.
Eric Seidel (no email)
Comment 3 2011-10-10 00:37:03 PDT
OK. Should be easy to teach the wrapper to avoid overriding you. But we could also mark this wontfix. I'm working on NRWT again as of tomorrow. Done with CSS regression distractions.
Ojan Vafai
Comment 4 2011-10-15 15:14:28 PDT
Created attachment 111151 [details] Patch
Ojan Vafai
Comment 5 2011-10-15 15:15:22 PDT
Sorry if this perl is crap. I bet there's a simple one-liner for this. I'm just a perl noob.
Adam Barth
Comment 6 2011-10-15 15:56:37 PDT
Comment on attachment 111151 [details] Patch Check out usingWebKit2() and usingLeaks() for some ideas about how to do this more compactly.
Ojan Vafai
Comment 7 2011-10-15 16:09:01 PDT
Created attachment 111153 [details] Patch
WebKit Review Bot
Comment 8 2011-10-15 17:17:34 PDT
Comment on attachment 111153 [details] Patch Clearing flags on attachment: 111153 Committed r97567: <http://trac.webkit.org/changeset/97567>
WebKit Review Bot
Comment 9 2011-10-15 17:17:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.