Bug 69707

Summary: Shrink RootInlineBox.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
darin: review-, darin: commit-queue-
Proposed patch v2 none

Andreas Kling
Reported 2011-10-08 13:23:25 PDT
There's some potential here.
Attachments
Proposed patch (3.28 KB, patch)
2011-10-08 13:35 PDT, Andreas Kling
no flags
Proposed patch (4.57 KB, patch)
2011-10-08 13:36 PDT, Andreas Kling
darin: review-
darin: commit-queue-
Proposed patch v2 (5.58 KB, patch)
2011-10-10 01:50 PDT, Andreas Kling
no flags
Andreas Kling
Comment 1 2011-10-08 13:35:31 PDT
Created attachment 110279 [details] Proposed patch
Andreas Kling
Comment 2 2011-10-08 13:36:21 PDT
Created attachment 110280 [details] Proposed patch Let's try again with a patch instead of a crashy SVG file..
WebKit Review Bot
Comment 3 2011-10-08 13:39:03 PDT
Attachment 110279 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4 2011-10-09 19:33:07 PDT
Comment on attachment 110280 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110280&action=review > Source/WebCore/rendering/InlineFlowBox.h:302 > +protected: I don’t think you should restate “protected”. It’s OK but a little strange, since we don’t normally repeat these. > Source/WebCore/rendering/InlineFlowBox.h:314 > + WTF::Unicode::Direction m_lineBreakBidiStatusEor : 5; > + WTF::Unicode::Direction m_lineBreakBidiStatusLastStrong : 5; > + WTF::Unicode::Direction m_lineBreakBidiStatusLast : 5; These need to be unsigned, not Direction, since Direction is an enum. It’s the same MSVC/enum/bitfield problem we have elsewhere. Also, probably don’t need the WTF:: prefix here because of the strange way WTF uses its namespace. I know you just moved these members, but they will malfunction if the direction is a value with the high bit set. If the code worked OK on Windows before there’s a chance we could get away with 4-bit bitfields.
Andreas Kling
Comment 5 2011-10-10 01:50:30 PDT
Created attachment 110338 [details] Proposed patch v2
Andreas Kling
Comment 6 2011-10-10 03:13:24 PDT
Comment on attachment 110338 [details] Proposed patch v2 Clearing flags on attachment: 110338 Committed r97052: <http://trac.webkit.org/changeset/97052>
Andreas Kling
Comment 7 2011-10-10 03:13:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.