Summary: | [File API] URL methods required arguments | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | abarth, annevk, ericu, ossy, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-10-07 21:19:59 PDT
Created attachment 110252 [details]
Patch
Comment on attachment 110252 [details] Patch Clearing flags on attachment: 110252 Committed r97544: <http://trac.webkit.org/changeset/97544> All reviewed patches have been landed. Closing bug. This test fails on Qt and on SL bot: --- /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-expected.txt +++ /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-actual.txt @@ -2,7 +2,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS webkitURL.createObjectURL() threw exception TypeError: Type error. +PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments. PASS webkitURL.revokeObjectURL() threw exception TypeError: Not enough arguments. PASS successfullyParsed is true Is it a JSC vs. V8 difference problem? As far as I remember in this case JSC result should be the platform independent result and the V8 result should platform specific. Reopen to fix expected results. -PASS webkitURL.createObjectURL() threw exception TypeError: Type error. +PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments. Not enough arguments is the correct text of the exception. We should change V8 to match JSC. @Mark: Would you like to take care of this, or should I? I added a Qt specific expected file to make the buildbot green. Please remove it with the proper fix. Thanks in advance. Moved JSC results to cross-platform dir. and then moved V8 specific results to platform/chromium. http://trac.webkit.org/changeset/97632 Seems this was only applicable to V8. |