Bug 69636

Summary:

Just use malloc/free when ADDRESS_SANITIZER is defined in RenderArena

Product:

WebKit

Reporter:

Martin Barbella <mbarbella>

Component:

WebCore Misc.

Assignee:

Abhishek Arya <inferno>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

abarth, inferno, kcc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch for address sanitizer in RenderArena	none
Patch	none

Martin Barbella

Reported 2011-10-07 09:27:08 PDT

Created attachment 110158 [details] Patch for address sanitizer in RenderArena A patch is included to use malloc and free without adding debug headers when ADDRESS_SANITIZER is defined in RenderArena.cpp. The address sanitizer would not be able to detect errors if reads or writes took place in the debug header. I'm working with Abhishek on cluster fuzz. Adam, could you please review it?

Attachments
Patch for address sanitizer in RenderArena (861 bytes, patch) 2011-10-07 09:27 PDT, Martin Barbella	no flags	Details Formatted Diff Diff
Patch (1.75 KB, patch) 2011-10-07 09:53 PDT, Abhishek Arya	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Abhishek Arya

Comment 1 2011-10-07 09:53:36 PDT

Created attachment 110161 [details] Patch

Darin Adler

Comment 2 2011-10-07 17:16:41 PDT

Comment on attachment 110161 [details] Patch OK

Abhishek Arya

Comment 3 2011-10-08 06:13:32 PDT

Comment on attachment 110161 [details] Patch Thanks a lot Darin.

WebKit Review Bot

Comment 4 2011-10-08 07:18:43 PDT

Comment on attachment 110161 [details] Patch Clearing flags on attachment: 110161 Committed r97009: <http://trac.webkit.org/changeset/97009>

WebKit Review Bot

Comment 5 2011-10-08 07:18:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.