Bug 69625

Summary:

Shrink StyleInheritedData.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Andreas Kling

Reported 2011-10-07 07:01:50 PDT

Let's fill the padding at the end of RefCounted with some of StyleInheritedData's members.

Attachments
Proposed patch (2.99 KB, patch) 2011-10-07 07:04 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2011-10-07 07:04:48 PDT

Created attachment 110141 [details] Proposed patch

WebKit Review Bot

Comment 2 2011-10-07 07:08:05 PDT

Attachment 110141 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/style/StyleInheritedData.h:51: horizontal_border_spacing is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/rendering/style/StyleInheritedData.h:52: vertical_border_spacing is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2011-10-07 07:27:38 PDT

Comment on attachment 110141 [details] Proposed patch Clearing flags on attachment: 110141 Committed r96935: <http://trac.webkit.org/changeset/96935>

Andreas Kling

Comment 4 2011-10-07 07:27:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.