Bug 69625 - Shrink StyleInheritedData.
Summary: Shrink StyleInheritedData.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-07 07:01 PDT by Andreas Kling
Modified: 2011-10-07 07:27 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (2.99 KB, patch)
2011-10-07 07:04 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-07 07:01:50 PDT 
Let's fill the padding at the end of RefCounted with some of StyleInheritedData's members.
Comment 1 Andreas Kling 2011-10-07 07:04:48 PDT 
Created attachment 110141 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-10-07 07:08:05 PDT 
Attachment 110141 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/style/StyleInheritedData.h:51:  horizontal_border_spacing is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/rendering/style/StyleInheritedData.h:52:  vertical_border_spacing is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2011-10-07 07:27:38 PDT 
Comment on attachment 110141 [details]
Proposed patch

Clearing flags on attachment: 110141

Committed r96935: <http://trac.webkit.org/changeset/96935>
Comment 4 Andreas Kling 2011-10-07 07:27:46 PDT 
All reviewed patches have been landed.  Closing bug.