Bug 69621

Summary: Remove some static functions of HTMLSelectElement
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Minor CC: rniwa, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 69518    
Bug Blocks: 69701    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2011-10-07 06:29:06 PDT
Remove some static functions of HTMLSelectElement
Attachments
Patch (18.11 KB, patch)
2011-10-07 06:37 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-10-07 06:37:28 PDT
Created attachment 110134 [details] Patch
Darin Adler
Comment 2 2011-10-07 08:20:22 PDT
Comment on attachment 110134 [details] Patch Another important refactoring here is to eliminate the SelectElement and OptionElement classes entirely. I was working on that yesterday (bad timing, I guess) but might not get back to it, though.
Ryosuke Niwa
Comment 3 2011-10-07 10:03:01 PDT
(In reply to comment #2) > (From update of attachment 110134 [details]) > Another important refactoring here is to eliminate the SelectElement and OptionElement classes entirely. I was working on that yesterday (bad timing, I guess) but might not get back to it, though. SelectElement has been removed in http://trac.webkit.org/changeset/96907. So I guess we just need to get rid of OptionElement now.
WebKit Review Bot
Comment 4 2011-10-08 02:04:25 PDT
Comment on attachment 110134 [details] Patch Clearing flags on attachment: 110134 Committed r97007: <http://trac.webkit.org/changeset/97007>
WebKit Review Bot
Comment 5 2011-10-08 02:04:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.