Bug 69592

Summary: Pass "accept" mime type information into FileChooser at all call sites
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Pass accept attribute information to ports via FileChooser none

Joseph Pecoraro
Reported 2011-10-06 18:48:01 PDT
From discussion on: <http://webkit.org/b/63039> FileChooser should be only created when we need to choose files. > > Is there a particular reason that this FileChooser doesn't set the acceptTypes? > > It looks like the accept="..." mime type filter would get ignored in this case, > > but it is respected with the click/runOpenPanel case. > > There is no reason. We had better pass acceptTypes. > Chromium's enumeratChosenDirectory() implementaion doesn't have the acceptTypes parameter > for now. So adding acceptTypes here is harmless. So this covers adding it! Patch to follow.
Attachments
[PATCH] Pass accept attribute information to ports via FileChooser (1.31 KB, patch)
2011-10-06 18:51 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-10-06 18:51:16 PDT
Created attachment 110075 [details] [PATCH] Pass accept attribute information to ports via FileChooser Added.
Kent Tamura
Comment 2 2011-10-06 18:53:24 PDT
Comment on attachment 110075 [details] [PATCH] Pass accept attribute information to ports via FileChooser OK
WebKit Review Bot
Comment 3 2011-10-06 19:54:47 PDT
Comment on attachment 110075 [details] [PATCH] Pass accept attribute information to ports via FileChooser Clearing flags on attachment: 110075 Committed r96895: <http://trac.webkit.org/changeset/96895>
WebKit Review Bot
Comment 4 2011-10-06 19:54:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.