Bug 69538

Summary: InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2011-10-06 10:27:13 PDT
The InlineBox::m_hasVirtualLogicalHeight flag is only initialized by the constructor if built with ENABLE(SVG), and furthermore InlineBox::logicalHeight() only checks it if built with ENABLE(SVG). Since this mechanism is used by TrailingFloatsRootInlineBox, it shouldn't be limited to SVG builds.
Attachments
Proposed patch (2.29 KB, patch)
2011-10-06 10:30 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-10-06 10:30:46 PDT
Created attachment 109974 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-10-06 10:52:24 PDT
Comment on attachment 109974 [details] Proposed patch Clearing flags on attachment: 109974 Committed r96832: <http://trac.webkit.org/changeset/96832>
WebKit Review Bot
Comment 3 2011-10-06 10:52:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.