Summary: | [GTK] Add estimated-progress property to WebKitWebLoaderClient | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, pnormand, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 69506 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-10-06 03:24:34 PDT
Created attachment 109939 [details]
Patch
Property is called estimated-progress instead of just progress to make it clear that the value is an estimation.
Comment on attachment 109939 [details]
Patch
Looks good to me API wise.
Comment on attachment 109939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109939&action=review I think estimated-progress is fine. :) > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:259 > + * An estimate of the percent complete for a document load. This complete->completion Maybe you should say "for the current loading operation." It includes subresources and subdocuments too, so maybe you shouldn't mention the document. Might want to explicitly say that it includes all subresources, actually. > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:264 > + * to be received for a document, including all it's possible subresources. it's -> its > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:270 > + "An estimate of the percent complete for a document load", complete -> completion > Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:80 > + fixture->progress = 0.; No need for the extra period here. (In reply to comment #3) > (From update of attachment 109939 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109939&action=review > > I think estimated-progress is fine. :) > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:259 > > + * An estimate of the percent complete for a document load. This > > complete->completion Maybe you should say "for the current loading operation." It includes subresources and subdocuments too, so maybe you shouldn't mention the document. Might want to explicitly say that it includes all subresources, actually. It already mentions it: * The value is an estimate based on the total number of bytes expected * to be received for a document, including all it's possible subresources. > > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:264 > > + * to be received for a document, including all it's possible subresources. > > it's -> its Ok. > > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:270 > > + "An estimate of the percent complete for a document load", > > complete -> completion Ok. > > Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:80 > > + fixture->progress = 0.; > > No need for the extra period here. Ok. Committed r96833: <http://trac.webkit.org/changeset/96833> |