Bug 69509 - [GTK] Add estimated-progress property to WebKitWebLoaderClient
Summary: [GTK] Add estimated-progress property to WebKitWebLoaderClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 69506
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-06 03:24 PDT by Carlos Garcia Campos
Modified: 2011-10-06 11:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.39 KB, patch)
2011-10-06 03:29 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-10-06 03:24:34 PDT 
To monitor the estimated progress of a load operation.
Comment 1 Carlos Garcia Campos 2011-10-06 03:29:42 PDT 
Created attachment 109939 [details]
Patch

Property is called estimated-progress instead of just progress to make it clear that the value is an estimation.
Comment 2 Philippe Normand 2011-10-06 05:50:44 PDT 
Comment on attachment 109939 [details]
Patch

Looks good to me API wise.
Comment 3 Martin Robinson 2011-10-06 08:39:27 PDT 
Comment on attachment 109939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109939&action=review

I think estimated-progress is fine. :)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:259
> +     * An estimate of the percent complete for a document load. This

complete->completion Maybe you should say "for the current loading operation." It includes subresources and subdocuments too, so maybe you shouldn't mention the document. Might want to explicitly say that it includes all subresources, actually.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:264
> +     * to be received for a document, including all it's possible subresources.

it's -> its

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:270
> +                                                        "An estimate of the percent complete for a document load",

complete -> completion

> Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:80
> +    fixture->progress = 0.;

No need for the extra period here.
Comment 4 Carlos Garcia Campos 2011-10-06 10:59:12 PDT 
(In reply to comment #3)
> (From update of attachment 109939 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109939&action=review
> 
> I think estimated-progress is fine. :)
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:259
> > +     * An estimate of the percent complete for a document load. This
> 
> complete->completion Maybe you should say "for the current loading operation." It includes subresources and subdocuments too, so maybe you shouldn't mention the document. Might want to explicitly say that it includes all subresources, actually.

It already mentions it:

* The value is an estimate based on the total number of bytes expected                                                                                                                  
* to be received for a document, including all it's possible subresources.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:264
> > +     * to be received for a document, including all it's possible subresources.
> 
> it's -> its

Ok.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:270
> > +                                                        "An estimate of the percent complete for a document load",
> 
> complete -> completion

Ok.

> > Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:80
> > +    fixture->progress = 0.;
> 
> No need for the extra period here.

Ok.
Comment 5 Carlos Garcia Campos 2011-10-06 11:02:23 PDT 
Committed r96833: <http://trac.webkit.org/changeset/96833>