Bug 69489

Summary: [chromium] Remove USE(THREADED_COMPOSITING) from the tree
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED WONTFIX    
Severity: Normal CC: enne, fishd, jamesr, kbr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 69528, 69618    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

James Robinson
Reported 2011-10-05 17:34:30 PDT
[chromium] Remove USE(THREADED_COMPOSITING) from the tree
Attachments
Patch (5.50 KB, patch)
2011-10-05 17:35 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2011-10-06 15:35 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-10-05 17:35:05 PDT
Created attachment 109890 [details] Patch
James Robinson
Comment 2 2011-10-05 17:36:07 PDT
we don't compile currently with WTF_USE_THREADED_COMPOSITING set
WebKit Review Bot
Comment 3 2011-10-06 00:11:16 PDT
Comment on attachment 109890 [details] Patch Clearing flags on attachment: 109890 Committed r96791: <http://trac.webkit.org/changeset/96791>
WebKit Review Bot
Comment 4 2011-10-06 00:11:20 PDT
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 5 2011-10-06 15:35:31 PDT
Created attachment 110045 [details] Patch
James Robinson
Comment 6 2011-10-06 15:38:07 PDT
I figured out why this test failed on mac and win - a fascinating to debug issue. The change with comment is in CCLayerTreeHostTest::onEndTest(). I'm not completely sure how this passed on linux before, I guess that the scheduling just worked out such that it worked. Darin - the webkit_support::QuitMessageLoop() API seems a little error-prone, or maybe it just needs a comment. MessageLoop::Quit() has a friendly comment explaining that pending tasks will run after the call to Quit() returns, but you just have to magically know that for the webkit_support version which tripped up this test.
James Robinson
Comment 7 2011-10-06 17:16:51 PDT
Comment on attachment 110045 [details] Patch Clearing flags on attachment: 110045 Committed r96879: <http://trac.webkit.org/changeset/96879>
James Robinson
Comment 8 2011-10-06 17:16:56 PDT
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 9 2011-10-07 18:57:43 PDT
Looks like this isn't gonna stick because our tests are crashy on shutdown and that last change wasn't sufficient to resolve it. http://trac.webkit.org/changeset/96930
Stephen Chenney
Comment 10 2013-04-09 16:28:15 PDT
Marking test failures as WontFix. Bug is still accessible and recording in TestExpectations.
Note You need to log in before you can comment on or make changes to this bug.