Bug 69485

Summary: BiquadFilterNode must not reset filter state if type attribute is set to the same type
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Rogers
Reported 2011-10-05 17:26:41 PDT
BiquadFilterNode must not reset filter state if type attribute is set to the same type
Attachments
Patch (2.20 KB, patch)
2011-10-05 17:28 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-10-05 17:28:28 PDT
Created attachment 109888 [details] Patch
Chris Rogers
Comment 2 2011-10-05 17:32:25 PDT
http://trac.webkit.org/changeset/96525 is causing glitches in some cases because a BiquadFilterNode .type attribute is set redundantly (to the same value multiple times) in some web audio pages. When this happens, the filter state is being reset (causing the glitch). The filter state should only be reset if the filter type is actually changing to a different type, in which case it is appropriate.
Kenneth Russell
Comment 3 2011-10-06 11:33:43 PDT
Comment on attachment 109888 [details] Patch Looks OK.
WebKit Review Bot
Comment 4 2011-10-06 12:19:52 PDT
Comment on attachment 109888 [details] Patch Clearing flags on attachment: 109888 Committed r96846: <http://trac.webkit.org/changeset/96846>
WebKit Review Bot
Comment 5 2011-10-06 12:19:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.