Bug 69473
| Summary: | Fix Windows build - it doesn't have a log2f() function... | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> |
| Component: | New Bugs | Assignee: | Chris Rogers <crogers> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aroben, darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Rogers
Fix Windows build - it doesn't have a log2f() function...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Rogers
Committed r96761: <http://trac.webkit.org/changeset/96761>
Adam Roben (:aroben)
Another option is to add a log2f function to wtf/MathExtras.h for Windows to use.
Darin Adler
In the past we have fixed problems like this by adding functions to MathExtras.h to smooth over differences between what platforms have in their <math.h> headers.
Adam Roben (:aroben)
Darin is like my much more eloquent shadow.
Darin Adler
Next time I will read before I write, because Adam is sure to get there first ;-)
Chris Rogers
Yes, this was certainly a quick fix. I wanted to get the chromium win builders happy ASAP.
The real fix for my code is not to use the log2() functions at all since they're inefficient. There's a much better algorithm for what I'm doing there (exponential ramp).
Chris Rogers
In the meantime, I'll try to fix this as you suggest.