| Summary: | Use std::reverse_iterator for ListHashSet reverse iterators | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | Web Template Framework | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | darin, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 69454 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-10-05 11:23:09 PDT
Created attachment 109827 [details]
Patch
Comment on attachment 109827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109827&action=review Did you test this? Does it work? > Source/JavaScriptCore/ChangeLog:13 > + (WTF::::rbegin): > + (WTF::::rend): You should remove these garbled lines from the change log. Attachment 109827 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/ListHashSet.h:80: reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:81: const_reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:274: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:275: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:278: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:328: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:329: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:332: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 8 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r96733: <http://trac.webkit.org/changeset/96733> This patch broke Mac builds: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/40228/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Build%29/builds/2691/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Build%29/builds/2025/steps/compile-webkit/logs/stdio Apparently on older toolsets, <iterator> is not compatible with -fno-exceptions. Maybe not practical if we support those old Mac toolsets? (In reply to comment #7) > Maybe not practical if we support those old Mac toolsets? It seems to me like if we include something that ends up including exception_defines.h we should be fine - it contains macros that define away try/catch. Comment on attachment 109827 [details] Patch Attachment 109827 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10073612 |