Bug 69422

Summary:

Web Inspector: provide a way for persisting worker inspector state

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, fishd, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

69434

Bug Blocks:

Attachments:

Description	Flags
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2011-10-05 07:24:48 PDT

Worker inspector may have a state(e.g. breakpoints) that should be restored when inspected worker restarts.

Attachments
Patch (26.97 KB, patch) 2011-10-05 08:32 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-10-05 08:32:09 PDT

Created attachment 109800 [details] Patch

WebKit Review Bot

Comment 2 2011-10-05 08:35:52 PDT

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

Yury Semikhatsky

Comment 3 2011-10-05 09:10:25 PDT

Committed r96710: <http://trac.webkit.org/changeset/96710>

Csaba Osztrogonác

Comment 4 2011-10-05 09:31:05 PDT

Comment on attachment 109800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109800&action=review > Source/WebCore/inspector/WorkerInspectorController.cpp:197 > + ASSERT(!m_inspectorFrontend); It broke debug builds: ../../../Source/WebCore/inspector/WorkerInspectorController.cpp: In member function 'void WebCore::WorkerInspectorController::restoreInspectorStateFromCookie(const WTF::String&)': ../../../Source/WebCore/inspector/WorkerInspectorController.cpp:197:5: error: 'm_inspectorFrontend' was not declared in this scope

Csaba Osztrogonác

Comment 5 2011-10-05 09:32:08 PDT

Oh, fix landed in http://trac.webkit.org/changeset/96713

Note You need to log in before you can comment on or make changes to this bug.