| Summary: | In WebKitTestRunner, text has font smoothing in pixel snapshots | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam, simon.fraser, webkit-bug-importer, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2011-10-04 21:04:22 PDT
Created attachment 109743 [details]
Patch
Comment on attachment 109743 [details]
Patch
WebKit preferences should not be used to set globals. Unfortunately on the Windows port, this preference already has this incorrect behavior. Moving forward, we need to deprecate it (which is easy since it’s in a private header), not add incorrect implementations on other platforms.
Created attachment 109850 [details]
Patch
Comment on attachment 109850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109850&action=review > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:53 > +WK_EXPORT void _WKContextSetShouldUseFontSmoothing(WKContextRef context, bool useFontSmoothing); What’s the deal with these underscore prefixes? (In reply to comment #5) > What’s the deal with these underscore prefixes? No idea. Some methods have them, some do not. Comment on attachment 109850 [details]
Patch
I don’t understand the motivation for the underscore prefix in _WKContextSetShouldUseFontSmoothing, but this patch seems otherwise great.
|