Bug 69396

Summary: In WebKitTestRunner, text has font smoothing in pixel snapshots
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Simon Fraser (smfr)
Reported 2011-10-04 21:04:22 PDT
Pixel results from WebKitTestRunner show that font smoothing is enabled, resulting in lots of spurious text differences.
Attachments
Patch (2.22 KB, patch)
2011-10-04 21:23 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2011-10-05 13:31 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-10-04 21:06:20 PDT
<rdar://problem/10235609>
Simon Fraser (smfr)
Comment 2 2011-10-04 21:23:14 PDT
Created attachment 109743 [details] Patch
mitz
Comment 3 2011-10-04 21:39:36 PDT
Comment on attachment 109743 [details] Patch WebKit preferences should not be used to set globals. Unfortunately on the Windows port, this preference already has this incorrect behavior. Moving forward, we need to deprecate it (which is easy since it’s in a private header), not add incorrect implementations on other platforms.
Simon Fraser (smfr)
Comment 4 2011-10-05 13:31:12 PDT
Created attachment 109850 [details] Patch
Darin Adler
Comment 5 2011-10-05 13:39:58 PDT
Comment on attachment 109850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109850&action=review > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:53 > +WK_EXPORT void _WKContextSetShouldUseFontSmoothing(WKContextRef context, bool useFontSmoothing); What’s the deal with these underscore prefixes?
Simon Fraser (smfr)
Comment 6 2011-10-05 13:41:02 PDT
(In reply to comment #5) > What’s the deal with these underscore prefixes? No idea. Some methods have them, some do not.
Darin Adler
Comment 7 2011-10-05 15:39:48 PDT
Comment on attachment 109850 [details] Patch I don’t understand the motivation for the underscore prefix in _WKContextSetShouldUseFontSmoothing, but this patch seems otherwise great.
Simon Fraser (smfr)
Comment 8 2011-10-05 17:08:23 PDT
http://trac.webkit.org/changeset/96770
Note You need to log in before you can comment on or make changes to this bug.