| Summary: | [CSS3 Regions] Make sure overflow:visible lets content spill out of regions. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | mihnea, ossy, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 57312 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dave Hyatt
2011-10-04 13:49:16 PDT
Created attachment 109677 [details]
Patch
Attachment 109677 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebCore/rendering/RenderRegion.cpp:129: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 109680 [details]
Patch
Attachment 109680 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 109684 [details]
Patch
Attachment 109684 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/JavaScriptCore/wtf/ListHashSet.h:410: const_reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:451: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Patch landed http://trac.webkit.org/changeset/96643, but unfortunately WebKit2 doesn't build on Qt, because of -Werror: cc1plus: warnings being treated as errors In file included from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebCore/rendering/HitTestResult.h:27, from ../include/WebCore/HitTestResult.h:1, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebHitTestResult.h:24, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.h:49, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebBackForwardList.h:32, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/SessionState.h:29, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebPageCreationParameters.h:30, from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebPageCreationParameters.cpp:27: /ramdisk/qt-linux-32-release-webkit2/build/Source/JavaScriptCore/wtf/ListHashSet.h:429: error: class ‘WTF::ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg>’ is implicitly friends with itself Patch landed in http://trac.webkit.org/changeset/96643 and buildfix laned in http://trac.webkit.org/changeset/96648. |