Bug 69342

Summary: force gray-aa if we must disable LCD due to drawing in a layer
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED INVALID    
Severity: Normal CC: brettw, eric, jamesr, kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mike Reed
Reported 2011-10-04 08:53:13 PDT
force gray-aa if we must disable LCD due to drawing in a layer
Attachments
Patch (1.76 KB, patch)
2011-10-04 08:54 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2011-10-04 12:05 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-10-04 08:54:50 PDT
Created attachment 109627 [details] Patch
James Robinson
Comment 2 2011-10-04 11:37:27 PDT
Comment on attachment 109627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109627&action=review > Source/WebCore/ChangeLog:8 > + No new tests. existing tests apply This is just a lie - we don't have any layout tests that detect this change in behavior (which is why it's been broken so often over the past few weeks). Ideally we'd have tests - but if you can't come up with a way to add them, at least be honest in the ChangeLog. I really think we do need an automated way to test this - be it layout tests or browser tests or something else. The current situation is we break it all the time and don't know until users complain.
Mike Reed
Comment 3 2011-10-04 12:05:29 PDT
Created attachment 109662 [details] Patch
Eric Seidel (no email)
Comment 4 2012-02-16 14:39:32 PST
James? (5-month ping) :)
James Robinson
Comment 5 2012-02-16 14:40:52 PST
There have been a lot of changes in this area, I'm not sure if this patch still applies. Mike?
Mike Reed
Comment 6 2012-02-22 04:21:08 PST
this patch is obsolete
Mike Reed
Comment 7 2012-02-22 09:53:19 PST
Thanks Stephen, I didn't know the convention (resolved + invalid) for deprecating an issue.
Note You need to log in before you can comment on or make changes to this bug.