| Summary: | force gray-aa if we must disable LCD due to drawing in a layer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Reed <reed> | ||||||
| Component: | New Bugs | Assignee: | Mike Reed <reed> | ||||||
| Status: | RESOLVED INVALID | ||||||||
| Severity: | Normal | CC: | brettw, eric, jamesr, kbr, senorblanco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mike Reed
2011-10-04 08:53:13 PDT
Created attachment 109627 [details]
Patch
Comment on attachment 109627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109627&action=review > Source/WebCore/ChangeLog:8 > + No new tests. existing tests apply This is just a lie - we don't have any layout tests that detect this change in behavior (which is why it's been broken so often over the past few weeks). Ideally we'd have tests - but if you can't come up with a way to add them, at least be honest in the ChangeLog. I really think we do need an automated way to test this - be it layout tests or browser tests or something else. The current situation is we break it all the time and don't know until users complain. Created attachment 109662 [details]
Patch
James? (5-month ping) :) There have been a lot of changes in this area, I'm not sure if this patch still applies. Mike? this patch is obsolete Thanks Stephen, I didn't know the convention (resolved + invalid) for deprecating an issue. |