Summary: | Web Inspector: saving JavaScript after live edit resets scroller position. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, me, ossy, paulirish, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2011-10-04 08:24:11 PDT
Created attachment 109971 [details]
Patch
Comment on attachment 109971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109971&action=review > Source/WebCore/inspector/front-end/UISourceCode.js:81 > + contentChanged: function() Looking at the current implementation, it seems that we can pass new content as a parameter here and avoid additional requestContent later. > Source/WebCore/inspector/front-end/UISourceCode.js:84 > + this._contentLoaded = false; this._content should also be cleared Committed r97056: <http://trac.webkit.org/changeset/97056> It broke inspector/debugger/script-formatter.html. On the SL bot: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r97056%20%2833778%29/inspector/debugger/script-formatter-pretty-diff.html On the Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r97056%20%2838357%29/inspector/debugger/script-formatter-pretty-diff.html Reopen to fix it. Comment on attachment 109971 [details]
Patch
remove r+ from landed patcg
Fix landed in http://trac.webkit.org/changeset/97060 |