Bug 69340

Summary: Web Inspector: saving JavaScript after live edit resets scroller position.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, me, ossy, paulirish, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Pavel Feldman 2011-10-04 08:24:11 PDT
1. Start editing
2. Hit Ctrl+Save (Cmd+Save)

scrol top is set to 0
Comment 1 Pavel Podivilov 2011-10-06 10:14:04 PDT
Created attachment 109971 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-07 02:00:03 PDT
Comment on attachment 109971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109971&action=review

> Source/WebCore/inspector/front-end/UISourceCode.js:81
> +    contentChanged: function()

Looking at the current implementation, it seems that we can pass new content as a parameter here and avoid additional requestContent later.

> Source/WebCore/inspector/front-end/UISourceCode.js:84
> +        this._contentLoaded = false;

this._content should also be cleared
Comment 3 Pavel Podivilov 2011-10-10 05:39:53 PDT
Committed r97056: <http://trac.webkit.org/changeset/97056>
Comment 5 Csaba Osztrogonác 2011-10-10 06:24:27 PDT
Comment on attachment 109971 [details]
Patch

remove r+ from landed patcg
Comment 6 Csaba Osztrogonác 2011-10-10 08:08:05 PDT
Fix landed in http://trac.webkit.org/changeset/97060
Comment 7 Pavel Feldman 2011-10-11 07:54:33 PDT
*** Bug 69842 has been marked as a duplicate of this bug. ***