| Summary: | [CSS3 Regions] Make overflow:hidden/auto/scroll objects work in regions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, mihnea, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 57312 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dave Hyatt
2011-10-03 22:26:37 PDT
Created attachment 109581 [details]
Patch
Comment on attachment 109581 [details] Patch Attachment 109581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9936515 New failing tests: http/tests/security/xssAuditor/cookie-injection.html fast/multicol/image-inside-nested-blocks-with-border.html fast/multicol/float-paginate.html fast/multicol/client-rects.html fast/multicol/span/span-as-immediate-columns-child-dynamic.html fast/multicol/span/span-as-immediate-child-generated-content.html fast/multicol/column-rules.html fast/multicol/column-count-with-rules.html fast/multicol/float-paginate-complex.html fast/multicol/span/span-as-immediate-child-complex-splitting.html fast/multicol/border-padding-pagination.html fast/multicol/column-break-with-balancing.html fast/multicol/span/anonymous-split-block-crash.html fast/multicol/span/span-as-immediate-child-property-removal.html fast/forms/input-spinbutton-capturing.html fast/forms/input-number-large-padding.html fast/events/offsetX-offsetY.html fast/forms/input-number-events.html fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html Created attachment 109632 [details]
Patch
Changes from the previous patch:
(1) Added updated results for two multicol tests that progressed, since they relied on the buggy getClearDelta behavior before. Now that getClearDelta is patched for writing modes, the overflow sections properly shifted below the floats.
(2) Fixed failing tests caused by offsetFromLogicalTopOfFirstPage() bailing if you weren't in a render flow thread. Changed it to be like it used to be, and bail when you're not paginated.
Comment on attachment 109632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109632&action=review > Source/WebCore/rendering/RenderBlock.cpp:1815 > + // FIXME: Needs to use epsilon once we switch to float, see https://bugs.webkit.org/show_bug.cgi?id=64021 Indentation is off here. > Source/WebCore/rendering/RenderBlock.h:432 > + Extra whitespace. Comment on attachment 109632 [details] Patch Attachment 109632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9936580 New failing tests: fast/multicol/vertical-rl/float-avoidance.html fast/multicol/vertical-lr/float-avoidance.html Fixed. The two multicol tests that progressed will need to be rebaselined on all platforms. |