Bug 69313

Summary: [flexbox] take marginBeforeForChild into account when positioning children
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Ojan Vafai
Reported 2011-10-03 19:03:03 PDT
[flexbox] take marginBeforeForChild into account when positioning children
Attachments
Patch (5.26 KB, patch)
2011-10-03 19:03 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (6.83 KB, patch)
2011-10-05 16:55 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-10-03 19:03:31 PDT
Created attachment 109570 [details] Patch
Tony Chang
Comment 2 2011-10-05 14:55:19 PDT
Comment on attachment 109570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109570&action=review > LayoutTests/css3/flexbox/002.html:34 > +<div data-expected-height="120" class="flexbox"> Did you mean to add data-expected-height here? > LayoutTests/css3/flexbox/002.html:35 > + <div data-expected-width="200" data-offset-y="50" style="width: -webkit-flex(1 0 0); margin: 50px 0;"></div> Can we add a new test case rather than changing a test case? > LayoutTests/css3/flexbox/writing-modes.html:78 > - <div data-expected-height="150" data-offset-y="0" style="height: -webkit-flex(1 0 0);"></div> > + <div data-expected-height="150" data-offset-y="0" data-offset-x="50" style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div> Ditto. > LayoutTests/css3/flexbox/writing-modes.html:164 > - <div data-expected-height="150" data-offset-y="0" data-offset-x="580" style="height: -webkit-flex(1 0 0);"></div> > + <div data-expected-height="150" data-offset-y="0" data-offset-x="480" style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div> Ditto. > LayoutTests/css3/flexbox/writing-modes.html:172 > - <div data-expected-width="150" data-offset-y="180" data-offset-x="0" style="width: -webkit-flex(1 0 0);"></div> > + <div data-expected-width="150" data-offset-y="130" data-offset-x="0" style="width: -webkit-flex(1 0 0); margin: 100px 0 50px 0;"></div> Ditto.
Ojan Vafai
Comment 3 2011-10-05 16:55:39 PDT
Created attachment 109882 [details] Patch
Ojan Vafai
Comment 4 2011-10-05 17:00:29 PDT
Committed r96769: <http://trac.webkit.org/changeset/96769>
Note You need to log in before you can comment on or make changes to this bug.