Bug 69278

Summary: CSS 2.1 failure: block-non-replaced-width-008.htm
Product: WebKit Reporter: Robert Hogan <robert>
Component: CSSAssignee: Robert Hogan <robert>
Severity: Normal CC: dbates, hyatt, mitz, rniwa, robert, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://test.csswg.org/suites/css2.1/nightly-unstable/html4/block-non-replaced-width-008.htm
Bug Depends on:    
Bug Blocks: 47141    
Description Flags
Patch simon.fraser: review+

Description Robert Hogan 2011-10-03 12:09:24 PDT
The checked-in results for this test show a failure.
Comment 1 Robert Hogan 2011-10-03 13:37:08 PDT
Created attachment 109519 [details]
Comment 2 Robert Hogan 2011-10-04 12:20:21 PDT
Created attachment 109664 [details]
Comment 3 Simon Fraser (smfr) 2011-10-24 13:20:12 PDT
Comment on attachment 109664 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109664&action=review

> Source/WebCore/ChangeLog:11
> +          Include the margins in the calculation of logical width even when the containing block's
> +          width is zero. This is required by block-non-replaced-width-008.htm in the CSS test suite.

It would be better to refer to the section of the CSS 2.1 spec that requires this, not the test that is fixed by the change.
Comment 4 Robert Hogan 2011-10-29 12:17:01 PDT
Committed r98812: <http://trac.webkit.org/changeset/98812>
Comment 5 Ryosuke Niwa 2011-10-29 14:06:32 PDT
css2.1/20110323/block-non-replaced-width-008.htm and fast/replaced/width100percent-searchfield.html appear to have started failing after this patch:

Could you rebaseline or skip them?
Comment 6 Ryosuke Niwa 2011-10-29 15:04:27 PDT
Mac rebaseline done in http://trac.webkit.org/changeset/98818.