Bug 69276

Summary: BiquadFilterNode should explicitly expose filter type constants in IDL
Product: WebKit Reporter: Chris Rogers <crogers>
Component: Web AudioAssignee: Chris Rogers <crogers>
Status: RESOLVED INVALID    
Severity: Normal CC: crogers, rtoy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Possible implementation none

Chris Rogers
Reported 2011-10-03 12:03:55 PDT
In the Web Audio API specification, the BiquadFilterNode interface defines filter type constants: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#BiquadFilterNode-section These need to be exposed to JavaScript in the IDL.
Attachments
Possible implementation (2.25 KB, patch)
2011-11-18 13:31 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2011-11-18 13:31:24 PST
Created attachment 115861 [details] Possible implementation A possible patch for BiquadFilterNode to expose the filter constants in IDL. This was tested on chromium and it works. Did not test with Safari.
Raymond Toy
Comment 2 2011-11-18 15:34:43 PST
That patch isn't needed. If filter is a BiquadFilterNode, then filter.LOWPASS is 0, filter.HIGHPASS is 1, and so on.
Chris Rogers
Comment 3 2012-03-15 15:04:45 PDT
filter constants are already defined - closing
Note You need to log in before you can comment on or make changes to this bug.