Summary: | [Chromium] Fix position check for double tap gesture detection | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Varun Jain <varunjain> | ||||||||
Component: | New Bugs | Assignee: | Varun Jain <varunjain> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, dglazkov, fishd, rjkroege, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Varun Jain
2011-10-03 11:19:00 PDT
Created attachment 109512 [details]
Patch
Comment on attachment 109512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review Looks largely ok to me. > ChangeLog:4 > + should not be detected if thw two taps are far from each other. typo: thw > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97 > + IntPoint m_lastClickPosition; At some point, this will all need to be refactored. But not now. > Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382 > +#if OS(MAC_OS_X) How about looking into why later? (There's already a bug for it.) Created attachment 109523 [details]
Patch
(In reply to comment #2) > (From update of attachment 109512 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review > > Looks largely ok to me. > > > ChangeLog:4 > > + should not be detected if thw two taps are far from each other. > > typo: thw Done > > > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97 > > + IntPoint m_lastClickPosition; > > At some point, this will all need to be refactored. But not now. > > > Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382 > > +#if OS(MAC_OS_X) > > How about looking into why later? (There's already a bug for it.) Yes I do plan to look into this later (if you do not get to it first) Created attachment 109537 [details]
Patch
Comment on attachment 109537 [details]
Patch
OK
Comment on attachment 109537 [details] Patch Clearing flags on attachment: 109537 Committed r96657: <http://trac.webkit.org/changeset/96657> All reviewed patches have been landed. Closing bug. |