Bug 69230

Summary: Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2011-10-02 16:41:56 PDT
Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
Attachments
Patch (30.83 KB, patch)
2011-10-02 16:44 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-02 16:44:38 PDT
Created attachment 109431 [details] Patch
Anders Carlsson
Comment 2 2011-10-02 17:33:25 PDT
Comment on attachment 109431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109431&action=review > Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:537 > + // FIXME: This code is mirrored in Frame.cpp. It would be nice to make the Mac code call the platform-agnostic > + // code, which would require converting the NSArray of NSStrings to a Vector of Strings somewhere along the way. Is this comment still relevant?
Sam Weinig
Comment 3 2011-10-02 17:39:40 PDT
Committed r96480: <http://trac.webkit.org/changeset/96480>
Note You need to log in before you can comment on or make changes to this bug.