Summary: | [CSS3 Regions] Make positioned objects work properly with regions. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, mihnea, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 57312 | ||||||
Attachments: |
|
Description
Dave Hyatt
2011-09-30 18:18:42 PDT
Created attachment 109387 [details]
Patch
Comment on attachment 109387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109387&action=review > Source/WebCore/rendering/RenderBlock.h:266 > + LayoutUnit startOffsetForContent(LayoutUnit position) const { return style()->isLeftToRightDirection() ? logicalLeftOffsetForContent(position) :width() - logicalRightOffsetForContent(position); } There should be a space after the :. Comment on attachment 109387 [details] Patch Attachment 109387 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9898574 New failing tests: fast/block/positioning/auto/vertical-lr/004.html fast/block/positioning/auto/vertical-rl/003.html fast/block/positioning/auto/vertical-rl/004.html fast/block/positioning/auto/vertical-lr/003.html |