Bug 69202

Summary: [CSS3 Regions] Make positioned objects work properly with regions.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mihnea, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch sam: review+, webkit.review.bot: commit-queue-

Dave Hyatt
Reported 2011-09-30 18:18:42 PDT
Positioned objects need to use the first region as the ICB and behave properly in variable width regions.
Attachments
Patch (223.54 KB, patch)
2011-09-30 18:20 PDT, Dave Hyatt 		sam: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-09-30 18:20:28 PDT
Created attachment 109387 [details] Patch
Sam Weinig
Comment 2 2011-09-30 18:31:05 PDT
Comment on attachment 109387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109387&action=review > Source/WebCore/rendering/RenderBlock.h:266 > + LayoutUnit startOffsetForContent(LayoutUnit position) const { return style()->isLeftToRightDirection() ? logicalLeftOffsetForContent(position) :width() - logicalRightOffsetForContent(position); } There should be a space after the :.
WebKit Review Bot
Comment 3 2011-09-30 18:53:10 PDT
Comment on attachment 109387 [details] Patch Attachment 109387 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9898574 New failing tests: fast/block/positioning/auto/vertical-lr/004.html fast/block/positioning/auto/vertical-rl/003.html fast/block/positioning/auto/vertical-rl/004.html fast/block/positioning/auto/vertical-lr/003.html
Dave Hyatt
Comment 4 2011-09-30 20:07:07 PDT
Fixed in r96452 (the width() in startOffsetForContent turned into a logicalWidth() to fix those failing layout tests).
Note You need to log in before you can comment on or make changes to this bug.