Bug 69141

Summary:

[WK2]Adding C API interface for Web Inspector to handle inspector at client side

Product:

WebKit

Reporter:

chandra shekar vallala <chandra.vallala>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

andersca, cgarcia, gustavo, luiz, mrobinson, ravi.kasibhatla, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch for webkit changes	none
updated patch.	sam: review-, chandra.vallala: commit-queue?

chandra shekar vallala

Reported 2011-09-30 05:00:50 PDT

As part of https://bugs.webkit.org/show_bug.cgi?id=68235, basic implementation of WebInspector was added. - This bug is to implement docking/undocking of web inspector. - It also attempts to add the interface API for creation & destruction of inspector webview at client side rather than in WebKit.

Attachments
patch for webkit changes (15.43 KB, patch) 2011-10-12 08:33 PDT, chandra shekar vallala	no flags	Details Formatted Diff Diff
updated patch. (16.09 KB, patch) 2011-10-13 05:16 PDT, chandra shekar vallala	sam: review- chandra.vallala: commit-queue?	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

chandra shekar vallala

Comment 1 2011-09-30 05:01:48 PDT

Initial patch will be uploaded in couple of days.

Martin Robinson

Comment 2 2011-09-30 06:37:10 PDT

I'm concerned with adding default dock/undock behavior. How will you ensure that you are packing the widget into the parent container properly?

chandra shekar vallala

Comment 3 2011-10-04 04:30:26 PDT

(In reply to comment #2) > I'm concerned with adding default dock/undock behavior. How will you ensure that you are packing the widget into the parent container properly? The addition of interface API mentioned in the description of bug is to address precisely this issue. Since the client knows the actual widget hierarchy and can pack all the widgets in correct order on detach or attach calls, with this patch I am trying to delegate widget related activity to the client.

chandra shekar vallala

Comment 4 2011-10-12 08:33:34 PDT

Created attachment 110687 [details] patch for webkit changes This patch is about the creation of web-inspector window at client side.

chandra shekar vallala

Comment 5 2011-10-12 08:37:00 PDT

(In reply to comment #4) > Created an attachment (id=110687) [details] > patch for webkit changes > > This patch is about the creation of web-inspector window at client side. For creation of inspector window at client side, callbacks have been added to interface files which client can use to open/close/dock/undock inspector window into its current window packing.

chandra shekar vallala

Comment 6 2011-10-13 05:16:38 PDT

Created attachment 110831 [details] updated patch. updated the patch with the fix of win-ews build break.

Carlos Garcia Campos

Comment 7 2011-10-13 05:58:13 PDT

Comment on attachment 110831 [details] updated patch. This patch is not specific to GTK+ port, it adds new C API so I guess it should be reviewed by apple guys. You should probably rename it too.

chandra shekar vallala

Comment 8 2011-10-19 23:37:16 PDT

andersca/sam, Can either of you have a look at the attached patch?

Sam Weinig

Comment 9 2012-07-07 13:16:33 PDT

Comment on attachment 110831 [details] updated patch. This introduces GTK specific types WebKitWebViewBase, into the implementation layer.

Martin Robinson

Comment 10 2012-07-07 13:19:52 PDT

It's quite possible that this bug is obsolete now...

Note You need to log in before you can comment on or make changes to this bug.