| Summary: | LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antaryami Pandia <xqb748> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 109257 [details]
Patch
Comment on attachment 109257 [details]
Patch
In the future, please put some rationale in bug and/or ChangeLog. It's not always as easy to guess why a rewrite/refactoring is attempted as it is for this patch.
Comment on attachment 109257 [details] Patch Clearing flags on attachment: 109257 Committed r96403: <http://trac.webkit.org/changeset/96403> All reviewed patches have been landed. Closing bug. |
Rewrite fast/dom/HTMLInputElement/input-size-attribute.html with new style. older style:- input.setAttribute("size", "-1"); shouldBe("input.size", "20"); with new style:- shouldBe("input.setAttribute('size', '-1'); input.size", "20");