Bug 69129
| Summary: | [Qt][WK2] Fix sputnik tests after migrating to refactored Qt5 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Critical | CC: | ossy, yael |
| Priority: | P1 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 69104 | ||
Csaba Osztrogonác
All of them fail with this fail: (missing space after PASS text)
--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-expected.txt
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-actual.txt
@@ -1,6 +1,6 @@
S7.2_A1.1_T1
"-PASS "
"+PASS"
TEST COMPLETE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
There are 5010(all!) failing sputnik tests skipped in qt-wk2/Skipped now.
(And there are 470 sputnik tests run and pass on the WK2 bot.)
Csaba Osztrogonác
Similar whitespace differences:
- http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/editing/undo/undo-deleteWord-pretty-diff.html
- http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/editing/undo/5658727-pretty-diff.html
- ...
Csaba Osztrogonác
javascript code in sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1.html which print PASS message:
...
function printTestPassed(msg)
{
testPrint('<span><span class="pass">PASS</span> ' + escapeHTML(msg) + '</span>');
}
...
It seems Qt eat somehow the space after the PASS, before the escapeHTML(msg).
Csaba Osztrogonác
Sputnik tests work with newer Qt5, so I unskipped them: http://trac.webkit.org/changeset/96714