Bug 69117 – [chromium] Add WebKit API for sending input events to the compositor thread

• Component: New Bugs
• Status: RESOLVED FIXED

[James Robinson]

[chromium] Add WebKit API for sending input events to the compositor thread

[James Robinson]

Created attachment 109234 [details]
Patch

[James Robinson]

With this patch the unit tests all pass and as many layout tests pass as did before with use_threaded_compositing=1.  The actual browser hookup of the thread isn't done and will require a chromium change.

[James Robinson]

Created attachment 109235 [details]
with a #define to make a 2-sided patch easier

[WebKit Review Bot]

Attachment 109234 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/tests/CCThreadTest.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/src/WebCompositorImpl.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

(In reply to comment #4)
> Attachment 109234 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebKit/chromium/tests/CCThreadTest.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebKit/chromium/src/WebCompositorImpl.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
> Total errors found: 2 in 16 files
> 

I can't tell what sort order this script is expected - I ran the lines through sort(1) and they look fine to me.

[WebKit Review Bot]

Attachment 109235 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/tests/CCThreadTest.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/src/WebCompositorImpl.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

Created attachment 109238 [details]
put HAVE_WEBCOMPOSITOR ifdef somewhere useful

[James Robinson]

Chromium side is here: http://codereview.chromium.org/8081014/

[WebKit Review Bot]

Attachment 109238 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/tests/CCThreadTest.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/src/WebCompositorImpl.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shawn Singh]

I think you can at the very least separate the "offending" includes by an extra newline.   I think the style check only checks sorting for "clusters of includes", where each cluster is separated by a newline.

but, i could be wrong...

[James Robinson]

Created attachment 109240 [details]
Patch

[WebKit Review Bot]

Attachment 109240 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/tests/CCThreadTest.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/src/WebCompositorImpl.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 109240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109240&action=review

> Source/WebKit/chromium/public/WebCompositor.h:53
> +#endif // WebCompositor_h

ditto

> Source/WebKit/chromium/public/WebCompositorClient.h:43
> +#endif // WebCompositorClient_h

style-nit: I mistyped this... the style guide suggests putting a comment on the close
of the namespace, not on the #endif.  i just mixed that up when i was typing this file
earlier.  the other headers in WebKit/chromium/public/ do it that way.

>> Source/WebKit/chromium/tests/CCThreadTest.cpp:32
>> +#include "CCThreadImpl.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Perhaps this is saying that "CC" sorts before "cc"??

[James Robinson]

Committed r96392: <http://trac.webkit.org/changeset/96392>