Bug 69111

Summary:

[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

WebKit Qt

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, kenneth, kling, laszlo.gombos, vestbo, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alexis Menard (darktears)

Reported 2011-09-29 16:22:29 PDT

[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.

Attachments
Patch (4.90 KB, patch) 2011-09-29 16:44 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (5.25 KB, patch) 2011-10-04 10:34 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (5.44 KB, patch) 2011-10-05 05:15 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (5.46 KB, patch) 2011-10-05 05:59 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2011-09-29 16:44:59 PDT

Created attachment 109220 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2011-09-29 18:03:59 PDT

Comment on attachment 109220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41 > + QDir().mkpath(s_dataLocation); What if this fails?

Alexis Menard (darktears)

Comment 3 2011-09-30 05:27:17 PDT

(In reply to comment #2) > (From update of attachment 109220 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review > > > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41 > > + QDir().mkpath(s_dataLocation); > > What if this fails? We could just return empty paths then. Will update the patch on monday.

Alexis Menard (darktears)

Comment 4 2011-10-04 10:34:07 PDT

Created attachment 109641 [details] Patch

Alexis Menard (darktears)

Comment 5 2011-10-04 10:38:30 PDT

(In reply to comment #4) > Created an attachment (id=109641) [details] > Patch The new patch as a fallback to a sensible path if there is no DataLocation from QDesktopServices (it writes into home so the mkdir should work).

Simon Hausmann

Comment 6 2011-10-05 02:00:13 PDT

Comment on attachment 109641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109641&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:85 > + QDir().mkpath(defaultLocalStorageDirectory); Hm, this calls mkpath() every time, which for a given path /foo/bar/baz will stat() /foo, /foo/bar and /foo/bar/baz every time. Maybe that could be avoided :)

Alexis Menard (darktears)

Comment 7 2011-10-05 05:15:26 PDT

Created attachment 109775 [details] Patch

Kenneth Rohde Christiansen

Comment 8 2011-10-05 05:18:49 PDT

Comment on attachment 109775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109775&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:78 > + s_defaultDatabaseDirectory = defaultDataLocation() + QLatin1String("Databases"); Are you sure that defaultDataLocation always ends with a / ? It is user configurable right via QDesktopServies

Alexis Menard (darktears)

Comment 9 2011-10-05 05:59:11 PDT

Created attachment 109779 [details] Patch

WebKit Review Bot

Comment 10 2011-10-05 07:19:33 PDT

Comment on attachment 109779 [details] Patch Clearing flags on attachment: 109779 Committed r96702: <http://trac.webkit.org/changeset/96702>

WebKit Review Bot

Comment 11 2011-10-05 07:19:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.