Bug 69109

Summary:

Refactor out trivially duplicated code in DFGJITCodeGenerator.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

yuqiang.xian

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	oliver: review+

Gavin Barraclough

Reported 2011-09-29 16:14:23 PDT

Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp. For some function differences are trivial & make more sense to ifdef individually, and some Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.

Attachments
Fix (198.35 KB, patch) 2011-09-29 16:16 PDT, Gavin Barraclough	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2011-09-29 16:16:20 PDT

Created attachment 109214 [details] Fix

Gavin Barraclough

Comment 2 2011-09-29 16:28:12 PDT

Fixed in r96377

Note You need to log in before you can comment on or make changes to this bug.