Bug 69109

Summary: Refactor out trivially duplicated code in DFGJITCodeGenerator.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: yuqiang.xian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix oliver: review+

Description Gavin Barraclough 2011-09-29 16:14:23 PDT
Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp

Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.

For some function differences are trivial & make more sense to ifdef individually, and some Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.
Comment 1 Gavin Barraclough 2011-09-29 16:16:20 PDT
Created attachment 109214 [details]
Fix
Comment 2 Gavin Barraclough 2011-09-29 16:28:12 PDT
Fixed in r96377